[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Segfault in Perl bindings when commit touches a large number of files

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 23 Mar 2015 12:34:31 +0000

Philip Martin <philip.martin_at_wandisco.com> writes:

> I'm not familiar with this code, but looking at other code in the file I
> tried this:
>
> Index: ../src-1.9/subversion/bindings/swig/include/svn_types.swg
> ===================================================================
> --- ../src-1.9/subversion/bindings/swig/include/svn_types.swg (revision 1668117)
> +++ ../src-1.9/subversion/bindings/swig/include/svn_types.swg (working copy)
> @@ -1119,8 +1119,7 @@
> /* FIXME: This code is clearly buggy. The return value of sv_newmortal()
> is immediately overwritten by the return value
> of svn_swig_pl_from_md5(). */
> - ST(argvi) = sv_newmortal();
> - ST(argvi++) = svn_swig_pl_from_md5($1);
> + %append_output(svn_swig_pl_from_md5($1));
> }
> #endif

This makes svn_swig_pl_from_md5 follow the same pattern as
svn_swig_pl_from_stream. I've committed this to trunk as r1668618.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-03-23 13:35:50 CET

This is an archived mail posted to the Subversion Dev mailing list.