[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

JavaHL: Exceptions in LogMessageCallback.singleMessage should abort the log immediately

From: Marc Strapetz <marc.strapetz_at_syntevo.com>
Date: Mon, 16 Mar 2015 17:29:45 +0100

If e.g. a RuntimeException is thrown in
LogMessageCallback#singleMessage, it's not processed in
LogMessageCallback::singleMessage and the log is continued nevertheless:

(1) At line 77 in LogMessageCallback.cpp, there should be returned an
appropriate error code.

(2) After line 122, JNIUtil::isJavaExceptionThrown() should be called
and there should be returned an appropriate error code.

In both cases, the returned error code should result in stopping the
low-level log; rethrowing the Exception in RemoteSession::getLog won't
be necessary, as this can be established easily from within client code
itself.

-Marc
Received on 2015-03-16 17:30:00 CET

This is an archived mail posted to the Subversion Dev mailing list.