Re: svn commit: r1664523 - /subversion/trunk/subversion/tests/cmdline/upgrade_tests.py

On 11 March 2015 at 15:56, Bert Huijben <bert_at_qqmail.nl> wrote:
>
>> -----Original Message-----
>> From: Ivan Zhakov [mailto:ivan_at_visualsvn.com]
>> Sent: woensdag 11 maart 2015 13:03
>> To: Bert Huijben
>> Cc: dev_at_subversion.apache.org; philip_at_apache.org
>> Subject: Re: svn commit: r1664523 -
>> /subversion/trunk/subversion/tests/cmdline/upgrade_tests.py
>>
[...]

>> It's very likely that Python compiled to different version of sqlite.
>> But how it supposed to work? Is not sqlite compatible between
>> different versions? What is the minimum requirements? How packagers
>> should deal with such test failures?
>
> My guess would be that you need Sqlite 3.6.18 (2009-09-11) or later.
> https://www.sqlite.org/changes.html#version_3_6_18
>
> My Python on my primary test VM has Sqlite 3.6.21 builtin and has no problem running these tests.
>
> $ python
> ActivePython 2.7.2.5 (ActiveState Software Inc.) based on
> Python 2.7.2 (default, Jun 24 2011, 12:21:10) [MSC v.1500 32 bit (Intel)] on win
> 32
> Type "help", "copyright", "credits" or "license" for more information.
>>>> import sqlite3;
>>>> sqlite3.sqlite_version
> '3.6.21'
>
>
[[[
ActivePython 2.6.7.20 (ActiveState Software Inc.) based on
Python 2.6.7 (r267:88850, Jun 27 2011, 13:20:48) [MSC v.1500 64 bit
(AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import sqlite3;
>>> sqlite3.sqlite_version
'3.5.9'
>>>
]]]

And error is "DatabaseError: malformed database schema
(nodes_update_checksum_trigger) - near "OLD": syntax error"

Most likely our database schema is not compatible with SQLite 3.5.x.
sqlite.c has compile-time check to build with SQLite 3.7.12 at least,
but even latest Python from python.org has sqlite 3.6.21 bundled. That
means we could expect similiar problems in future.

I've updated to Python 2.7.8 for now and continue to review the change itself.

-- 
Ivan Zhakov