Re: Convenient array & hash iterators & accessors

On 06.03.2015 09:08, Greg Stein wrote:
> We've seen some of this kind of stuff in svn_iter.h, and it did not
> turn out to be useful. The additional concepts needed to
> learn/keep/use costed more than the incremental benefit.
>
> I find the SVN_ITER_T() and SVN_ARRAY_ITER() macros in your example to
> be rather inscrutable.

Agreed. The new macros don't really add any type safety, since they rely
on implicit conversions from void*. I'm also *very* scared of the
implicit, hidden qsort in the sorted.

It would make sense to design type-safe, light-weight container and
iterator template wrappers around the APR structures if we decided to
write code in C++. Since we're not, "explicit is better than implicit".

-- Brane
Received on 2015-03-06 09:55:49 CET