[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1664078 - in /subversion/trunk/subversion: include/private/ libsvn_ra/ libsvn_ra_local/ libsvn_ra_serf/ libsvn_ra_svn/ libsvn_subr/

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 05 Mar 2015 13:38:38 +0000

Philip Martin <philip.martin_at_wandisco.com> writes:

>> if (err)
>> {
>> + svn_pool_clear(scratch_pool);
>
> As this path always returns an error I think it would be clearer to
> destroy the temporary pool rather than clear it. I think it should be
> the parent sesspool rather than scratch_pool, as in the other error
> paths.

I've changed this in r1664344.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-03-05 14:39:54 CET

This is an archived mail posted to the Subversion Dev mailing list.