Re: svn commit: r1663780 - /subversion/trunk/subversion/include/svn_hash.h
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 4 Mar 2015 10:07:59 +0000
Branko and Bert, I'm still not sure I understand what is needed for the Windows build.
>>> -#ifdef SVN_DEBUG
> Bert Huijben wrote:
>> As noted on irc we have one .def file that is used for release and
We do want to use svn_hash__[sg]ets in maintainer builds from all libs, so you're saying I have to put it in that list. (Where is the list?)
>> And if it is in the list, it
So its definition should not be inside #ifdef. OK, it's not.
Branko Čibej wrote:
I can't find svn_error__trace mentioned inside any files in (root dir) or build/**.
The svn_error__trace definition is unconditional. (It has an #ifdef inside it, but that's not the main concern.)
The svn_error__trace declaration is inside #ifdef SVN_DEBUG (effectively; actually inside #ifdef SVN_ERR__TRACING which is defined iff SVN_DEBUG).
But Bert said yesterday I need to remove the #ifdef from the declaration, at least that's how I understood it so I did so in r1663780.
Now I don't know which is correct (#ifdef or not) and I understand I do need to add svn_hash__[gs]ets to a list of exports.
Can you clarify further what still needs to be done, if anything, please?
This is an archived mail posted to the Subversion Dev mailing list.