[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1663738 - in /subversion/trunk/subversion: libsvn_fs/fs-loader.c tests/cmdline/svnlook_tests.py tests/libsvn_fs/fs-test.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 03 Mar 2015 18:17:38 +0000

"Bert Huijben" <bert_at_qqmail.nl> writes:

>> -----Original Message-----
>> From: kotkov_at_apache.org [mailto:kotkov_at_apache.org]
>> Sent: dinsdag 3 maart 2015 17:44
>> To: commits_at_subversion.apache.org
>> Subject: svn commit: r1663738 - in /subversion/trunk/subversion: libsvn_fs/fs-
>> loader.c tests/cmdline/svnlook_tests.py tests/libsvn_fs/fs-test.c
>>
>> Author: kotkov
>> Date: Tue Mar 3 16:43:39 2015
>> New Revision: 1663738
>>
>> URL: http://svn.apache.org/r1663738
>> Log:
>> Don't expose internal transaction properties like 'svn:check-locks' through
>> the public FS API and error out on attempts to change them.
>
> I wish it would be possible to put these in their own property
> namespace, to avoid those list of properties to check against...
>
> But that is not really possible any more, is it?

The symbols are private to the FS layer, defined in
libsvn_fs/fs-loader.h, but they are stored on disk so effectively it
would be changing the on-disk format. If we changed the definition then
creating a txn with one library version and committing it with another
would silently do the wrong thing. I don't suppose that happens very
often, but I guess it is supposed to work.

We could change the unreleased svn:client-date to something like
svn:txn:client-date, and use svn:txn: for any others added in future.
CHECK_OOD has never been implemented so could be deprecated, leaving
only CHECK_LOCKS outside svn:txn:.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-03-03 19:18:08 CET

This is an archived mail posted to the Subversion Dev mailing list.