[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1663450 - /subversion/trunk/subversion/libsvn_ra_svn/editorp.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Tue, 3 Mar 2015 13:03:28 +0300

On 3 March 2015 at 01:26, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Mon Mar 2 22:26:07 2015
> New Revision: 1663450
>
> URL: http://svn.apache.org/r1663450
> Log:
> Following up on r1658194, fix removing tokens from the tokens cache.
> Just passing the token to svn_hash_sets() didn't work any more.
>
> * subversion/libsvn_ra_svn/editorp.c
> (ra_svn_handle_close_dir,
> ra_svn_handle_close_file): Properly handle svn_string_t tokens.
>
Good catch, Bert!

Do I understand correctly that last minute micro-optimization change
made in r1658194 [1] broke the 1.9.x branch (unbounded memory usage
and potential access to invalid memory)?

[1] http://svn.apache.org/r1658194

-- 
Ivan Zhakov
Received on 2015-03-03 11:04:16 CET

This is an archived mail posted to the Subversion Dev mailing list.