[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1655821 - in /subversion/trunk/subversion: libsvn_ra_serf/options.c tests/cmdline/redirect_tests.py

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 29 Jan 2015 21:51:33 +0100

> -----Original Message-----
> From: Branko Čibej [mailto:brane_at_wandisco.com]
> Sent: donderdag 29 januari 2015 21:22
> To: commits_at_subversion.apache.org
> Subject: Re: svn commit: r1655821 - in /subversion/trunk/subversion:
> libsvn_ra_serf/options.c tests/cmdline/redirect_tests.py
>
> On 29.01.2015 20:27, philip_at_apache.org wrote:
> > Author: philip
> > Date: Thu Jan 29 19:27:19 2015
> > New Revision: 1655821
> >
> > URL: http://svn.apache.org/r1655821
> > Log:
> > Distingush between permanent and temporary redirections to match the
> > 1.8 behaviour.
> >
> > * subversion/libsvn_ra_serf/options.c
> > (svn_ra_serf__exchange_capabilities): Permanent or temporary error.
> >
> > * subversion/tests/cmdline/redirect_tests.py
> > (redirected_copy): Extend with temporary redirect.
> >
> > Modified:
> > subversion/trunk/subversion/libsvn_ra_serf/options.c
> > subversion/trunk/subversion/tests/cmdline/redirect_tests.py
> >
> > Modified: subversion/trunk/subversion/libsvn_ra_serf/options.c
> > URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/optio
> ns.c?rev=1655821&r1=1655820&r2=1655821&view=diff
> >
> ================================================================
> ==============
> > --- subversion/trunk/subversion/libsvn_ra_serf/options.c (original)
> > +++ subversion/trunk/subversion/libsvn_ra_serf/options.c Thu Jan 29 19:27:19
> 2015
> > @@ -555,8 +555,9 @@ svn_ra_serf__exchange_capabilities(svn_r
> > && opt_ctx->handler->sline.code < 399)
> > {
> > return svn_error_createf(SVN_ERR_RA_SESSION_URL_MISMATCH, NULL,
> > - _("The repository reports that it was moved "
> > - "to '%s'"),
> > + (opt_ctx->handler->sline.code == 301
> > + ? _("Repository moved permanently to '%s'")
> > + : _("Repository moved temporarily to '%s'")),
> > opt_ctx->handler->location);
> > }
>
> I just noticed that we're probably handling the 307 status incorrectly,
> or not at all.

We only handle permanent redirects (status 301) *as* redirects for the automatic handling, during the opening of a session.
All the other redirect status values are just reported as an error accessing the repository.

        Bert
Received on 2015-01-29 21:52:55 CET

This is an archived mail posted to the Subversion Dev mailing list.