[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1655635 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Thu, 29 Jan 2015 16:57:58 +0300

On 29 January 2015 at 16:39, Philip Martin <philip.martin_at_wandisco.com> wrote:
> ivan_at_apache.org writes:
>
>> /* Create the 'current' file. */
>> - SVN_ERR(svn_io_file_create_empty(svn_fs_fs__path_current(fs, pool), pool));
>> SVN_ERR(svn_fs_fs__write_current(fs, 0, 1, 1, pool));
>
> This causes failures on Unix.
>
> svn_fs_fs__write_current() needs to use some file as a source of the
> permissions for the new file. At the moment the source file is the
> 'current' file itself which means the file must exist before calling
> svn_fs_fs__write_current().
>
Thanks!

I've reverted this change in r1655664.

Possible solution will be to add new function
svn_fs_fs__create_current() and use it in
svn_fs_fs__create_file_tree(), but I am not sure it's worth it.

-- 
Ivan Zhakov
Received on 2015-01-29 14:58:50 CET

This is an archived mail posted to the Subversion Dev mailing list.