[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1655008 - /subversion/trunk/subversion/tests/libsvn_fs_fs/fs-fs-pack-test.c

From: Branko ─îibej <brane_at_wandisco.com>
Date: Tue, 27 Jan 2015 14:57:40 +0100

On 27.01.2015 14:29, Ivan Zhakov wrote:
> On 27 January 2015 at 14:16, <stefan2_at_apache.org> wrote:
>> Author: stefan2
>> Date: Tue Jan 27 11:16:35 2015
>> New Revision: 1655008
>>
>> URL: http://svn.apache.org/r1655008
>> Log:
>> Make the test added in r1654933 somewhat more robust by using the
>> parser / serializer functions provided by FSFS.
>>
>> * subversion/tests/libsvn_fs_fs/fs-fs-pack-test.c
>> (stringbuf_find): Just return a position, not a pointer.
>> (plain_0_length): Modify the revision content using FSFS noderev I/O and
>> tweak the native structure instead of its serialized
>> format.
>>
>> Suggested by: danielsh
>>
> I think it's will be better to use pre-cooked FSFS repository created
> using documented reproduction script using older Subversion instead of
> manipulating revision files directly.

It would be great if we could do that for all (most?) of the C tests,
similar to the way it works now in the Python tests. I know the C tests
typically create specific repository layouts, but maybe we could
consolidate many of them to use the greek tree and maybe a couple variants.

-- Brane
Received on 2015-01-27 14:58:59 CET

This is an archived mail posted to the Subversion Dev mailing list.