[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn --version --verbose += /etc/os-release

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 27 Jan 2015 12:38:35 +0000

Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:

> Where should we introduce dual pools?

Every function that returns a result allocated in a pool is a candidate.
I think it requires more justification for such a function to be single

> The callstack is single-pool all
> the way to the public entry point svn_version_extended().

Maybe svn_version_extended() should have been dual pool from the start.

> We prefer to
> avoid creating subpools in functions that don't do a lot of work, so if
> we want to convert to dual-pools we'll need to revv that function.

svn_version_extended() runs subprocesses and reads files, in syscall
terms that might count as "a lot of work" so perhaps a subpool is

Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-01-27 13:39:08 CET

This is an archived mail posted to the Subversion Dev mailing list.