[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Testing equality between svnrdump and svnadmin dump

From: Bert Huijben <bert_at_qqmail.nl>
Date: Mon, 26 Jan 2015 15:24:00 +0100

> -----Original Message-----
> From: Branko Čibej [mailto:brane_at_wandisco.com]
> Sent: maandag 26 januari 2015 15:17
> To: dev_at_subversion.apache.org
> Subject: Re: Testing equality between svnrdump and svnadmin dump
>
> On 26.01.2015 14:13, Julian Foad wrote:
> > I attach the latest version of my dump/load cross-checking patch.
> >
> > Do we want to commit this? I think we should. It has been very useful in
> uncovering dump/load bugs and inconsistencies.
>
> Absolutely +1, more tests can't hurt.

I see added value in these tests, but can we please make this behavior optional before enabling for everybody all the time?

I don't see why every test in the testsuite needs a double dump and comparison in every testrun (on every test invocation)
(And then the patch appears to ignore the fact that we have tests that create multiple repositories)

I can't see why the coverage is better this way, than running this just in a single configuration... except by slowing developers down (and thereby reducing the number of new bugs... just by reducing their productivity)

With the same reasoning: better coverage is better, we can just as well remove the flag on which filesystem we test, and always run BDB and FSFS.
Or skip the check which RA layer, and run them all.

We separated these tests over multiple configurations for a reason, and I think this should behave the same way

        Bert
Received on 2015-01-26 15:26:05 CET

This is an archived mail posted to the Subversion Dev mailing list.