Re: svn commit: r1652157 - in /subversion/trunk/subversion: libsvn_wc/wc_db.c tests/cmdline/externals_tests.py

Philip Martin <philip.martin_at_wandisco.com> writes:

>> + /* Any previously cached children now have a new WCROOT. */
>> + for (hi = apr_hash_first(scratch_pool, db->dir_data);
>> + hi;
>> + hi = apr_hash_next(hi))
>> + {
>> + const char *abspath = apr_hash_this_key(hi);
>> + if (svn_dirent_is_ancestor(wcroot->abspath, abspath))
>> + svn_hash_sets(db->dir_data, abspath, wcroot);
>> + }
>> +
>> return SVN_NO_ERROR;
>> }
>
> This fixes the issue but I'm wondering if I should remove the entries
> rather than update them. Is it wrong for db->dir_cache to have entries
> for paths that are not directories and do not exist?

It is always possible for the disk tree to change outside of Subversion
so that entries in db->dir_cache refer to paths that are no longer
directories or no longer exist. I suppose that means there should be no
bad effects updating these child entries rather than removing them.

-- 
Philip