[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1652076 - /subversion/trunk/subversion/libsvn_fs_fs/index.c

From: Branko ─îibej <brane_at_wandisco.com>
Date: Thu, 15 Jan 2015 14:20:39 +0100

On 15.01.2015 13:38, ivan_at_apache.org wrote:
> Author: ivan
> Date: Thu Jan 15 12:38:13 2015
> New Revision: 1652076
>
> URL: http://svn.apache.org/r1652076
> Log:
> Fix mostly theoretical data corruption in log-addressing enabled FSFS
> repositories when physical-to-logical index will be more than 4 GB on
> 32-bit platform.
>
> * subversion/libsvn_fs_fs/index.c
> (svn_fs_fs__p2l_index_append): Use proper type (apr_uint64_t) for local
> variable that holds file size.

How about using svn_filesize_t instead, for clarity. Or apr_off_t which
should always have the required range.

-- Brane
Received on 2015-01-15 14:21:16 CET

This is an archived mail posted to the Subversion Dev mailing list.