[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1651980 - in /subversion/trunk/subversion: libsvn_wc/wc_db.c tests/libsvn_wc/op-depth-test.c

From: Branko ─îibej <brane_at_wandisco.com>
Date: Thu, 15 Jan 2015 10:34:34 +0100

On 15.01.2015 09:51, rhuijben_at_apache.org wrote:
> Author: rhuijben
> Date: Thu Jan 15 08:51:47 2015
> New Revision: 1651980
>
> URL: http://svn.apache.org/r1651980
> Log:
> Resolve the issue identified in r1651963, by properly calculating the depth
> of the location where the moved to information should be stored after another
> move.
>
> * subversion/libsvn_wc/wc_db.c
> (delete_update_movedto): Make this assertion maintainer only, like other
> similar checks in wc_db.c.
> (delete_node): Fix depth calculation.

If the depth calculation is now correct and the assertion doesn't get
triggered, the SVN_DEBUG is doubly useless because it masks bugs. If the
SVN_DEBUG had been there before, we'd never have got the original bug
report in the first place. Either leave the assertion in or rip it out.

-- Brane
Received on 2015-01-15 10:35:09 CET

This is an archived mail posted to the Subversion Dev mailing list.