[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Testing equality between svnrdump and svnadmin dump

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 13 Jan 2015 17:22:41 +0000

Bert Huijben wrote:
> I haven't reviewed all of this, but I'm wondering why in your patch
> [[
>    def parse_path(self):
> -    path = self.parse_line('Node-path: (.+)$', required=False)
> -    if not path and self.lines[self.current] == 'Node-path: \n':
> -      self.current += 1
> -      path = ''
> +    path = self.parse_line('Node-path: (.*)$', required=False)
> ]]
>
> This replaces '.+' with '.*'
>
> I was wondering why this was necessary?

That's just a bug fix. The empty path '' is a valid path. (A path may start with a slash or not.) This part of the parser was simply wrong, before. It was only used in a few tests and hadn't been used on a root path yet.

Thanks for looking.

- Julian
Received on 2015-01-13 18:25:38 CET

This is an archived mail posted to the Subversion Dev mailing list.