Re: svn commit: r1649029 - in /subversion/trunk/subversion/libsvn_fs_x: ./ dag.c tree.c

On Mon, Jan 12, 2015 at 06:54:22PM +0300, Ivan Zhakov wrote:
> Subversion community guide is very specific about proper log messages
> and I don't understand why this commit (and other previous FSX "merge"
> commits") does not follow it.
>
> Quoting Subversion community guide [1] again:
> [[[
> The log message should name every affected function, variable, macro,
> makefile target, grammar rule, etc, including the names of symbols
> that are being removed in this commit. This helps people searching
> through the logs later. Don't hide names in wildcards, because the
> globbed portion may be what someone searches for later.
> ]]]
>
> There is very good reason that every affected identifier should be
> mentioned in log message.

We don't usually do this in merge commits.

Would you really expect this in a 'sync with trunk' merge on a feature
branch that hasn't been updated in a while?
It would be a lot of duplicated work.

The same can be said for merges between subfolders.

Of course, merge commits should name the revisions merged so their log
messages cound be found easily.
Received on 2015-01-12 17:15:01 CET