[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1649029 - in /subversion/trunk/subversion/libsvn_fs_x: ./ dag.c tree.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Mon, 12 Jan 2015 18:25:12 +0300

 5 January 2015 at 15:49, Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> wrote:
> On Fri, Jan 2, 2015 at 3:21 PM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
>> On 2 January 2015 at 16:46, <stefan2_at_apache.org> wrote:
>> > Author: stefan2
>> > Date: Fri Jan 2 13:46:57 2015
>> > New Revision: 1649029
>> >
>> > URL: http://svn.apache.org/r1649029
>> > Log:
>> > Sync FSX with FSFS: Merge DAG-related sub-pool introduction
>> > patches r1647905, r1648243, r1648253 and r1648272 from FSFS
>> > and resolve the usual text conflicts due to naming differences.
>> > Block revisions r1648230, r1648238, r1648241, r1648242 and r1648532.
>> >
>> Stefan,
>>
>> You've already got veto for these revisions (r1648243 etc) when you
>> have committed them to FSFS and reverted on trunk. What is the point
>> to merge them to FSX?
>
> The veto was based upon the crash Evgeny found.
> That crash was caused by r1648238.
>
As far as I understand there were two veto reasons against r1648253:
crash and APR pools usage violation.

Also, it seems that this commit has another problems:
1. It doesn't have proper log message [1].
2. It mixes different unrelated changes in one commit, while it will
be much easier to review them separately.

Mentioning all changed identifiers in log message is important.
Quoting Subversion community guide [1]
[[[
The log message should name every affected function, variable, macro,
makefile target, grammar rule, etc, including the names of symbols
that are being removed in this commit. This helps people searching
through the logs later. Don't hide names in wildcards, because the
globbed portion may be what someone searches for later.
]]]

We use the shortened log messages for backports to release branches,
but FSX is not a branch. This code is in trunk.

[1] https://subversion.apache.org/docs/community-guide/conventions.html#log-messages

---
Ivan Zhakov
Received on 2015-01-12 16:28:26 CET

This is an archived mail posted to the Subversion Dev mailing list.