[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [serf-dev] Re: [PATCH] Serf crash on spurious data between responses

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 12 Jan 2015 11:22:34 +0000

Lieven Govaerts <lgo_at_mobsol.be> writes:

> You're trying to capture the situation where serf has:
> - finished writing a request ( req_bkt == NULL && writing_started )
> - has no more requests in the pending queue
> - and receives actual bytes of data.
> Right?
>
> Looks like your patch is a correct way to fix the problem. Some
> comments would be welcome, and if you have the time a test.

I'm not familiar with serf's testsuite. The scenario:

  - client sends first request
  - server sends response
  - server sends extra data, say '\n'
  - client handles first request
  - client creates a second request
  - client calls serf to send second, pipelined, request
  - serf reads extra data
  - serf attempts to pass the extra data to client's callbacks

At this point serf has not called setup_request so although the client
has created a request is not ready to receive data. How do I go about
writing such a test?

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-01-12 12:23:08 CET

This is an archived mail posted to the Subversion Dev mailing list.