[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1649012 [1/3] - in /subversion/trunk: ./ subversion/libsvn_fs_x/

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Fri, 2 Jan 2015 21:09:52 +0400

On 2 January 2015 at 18:59, Philip Martin <philip.martin_at_wandisco.com> wrote:
> Ivan Zhakov <ivan_at_visualsvn.com> writes:
>
>> Do I understand correctly that you have merged branch without
>> resolving concerns about dirent_t structure naming raised dev@ list
>> two weeks ago [1] ?
>
> The names appear to have been changed (dirent_t to svn_fs_x__dirent_t)
> as part of the merge commit.
>
What commit do you mean?

I see the following in this diff email:
[[[
@@ -2411,8 +2407,8 @@ sorted(apr_array_header_t *entries)
 static int
 compare_dirents(const void *a, const void *b)
 {
- const svn_fs_dirent_t *lhs = *((const svn_fs_dirent_t * const *) a);
- const svn_fs_dirent_t *rhs = *((const svn_fs_dirent_t * const *) b);
+ const dirent_t *lhs = *((const dirent_t * const *) a);
+ const dirent_t *rhs = *((const dirent_t * const *) b);

   return strcmp(lhs->name, rhs->name);
 }
]]]

-- 
Ivan Zhakov
Received on 2015-01-02 18:10:41 CET

This is an archived mail posted to the Subversion Dev mailing list.