[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: GNOME keyring in Subclipse bug

From: Mark Phippard <markphip_at_gmail.com>
Date: Thu, 20 Nov 2014 08:59:18 -0500

On Thu, Nov 20, 2014 at 7:37 AM, Philip Martin <philip.martin_at_wandisco.com>
wrote:

> Philip Martin <philip.martin_at_wandisco.com> writes:
>
> > I suppose the problem might be connected to running concurrent GLIB
> > event loops in two different threads. Subversion does
> >
> > loop = g_main_loop_new(NULL);
> > g_main_loop_run(loop);
> > ...
> > g_main_loop_quit(loop);
> >
> > where NULL causes g_main_loop_new to use the default GMainContext. I
> > suspect that is an error:
> >
> > https://tecnocode.co.uk/2014/03/27/what-is-gmaincontext/
> >
> > "Libraries should never use g_main_context_default() (or,
> > equivalently, pass NULL to a GMainContext-typed parameter)"
> >
> > Perhaps we should be doing something like the patch below. It can't be
> > precisely that because it doesn't work when I try it, the
> > g_main_loop_run() call hangs.
>
> gnome-keyring has a synchronous API that pushes all the event handling
> into the gnome-keyring library. As well as making our code much simpler
> the gnome-keyring is more likely to get it right. I've committed
> r1640730. Are you able to confirm whether that fixes the problem?
>
>
I might be able to try this as I would like to see it get backported. I do
not have a Linux dev box currently so might take a while. Fortunately, I
did just install Ubuntu on an old laptop so I can give it a try. Anything
I should know about the libtool issues on Debian systems? I recall threads
in the past when people try to do SVN dev.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
Received on 2014-11-20 14:59:46 CET

This is an archived mail posted to the Subversion Dev mailing list.