[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: GNOME keyring in Subclipse bug

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 19 Nov 2014 13:58:36 +0000

"Fitzpatrick, Ben" <ben.fitzpatrick_at_metoffice.gov.uk> writes:

> I can reproduce (what I think is) the crash in Eclipse 4.3 +
> Subclipse 1.10.6 + JavaHL 1.8.10 + Subversion 1.8.10.
>
> If you have a Subversion config that allows use of gnome-keyring (e.g. a
> default or blank configuration on a Unix-like system), you'll get an
> unfriendly prompt that wants to disable all password caching.

Is that some Subclipse thing? Is there a Subversion equivalent? Is it
related to one of the errors messages in Subversion's gnome_keyring.c?

> If you cancel
> that prompt, but then start connecting to authenticated Subversion
> repositories (via e.g. Window -> Open Perspective -> ... -> SVN repository
> exploring), you'll be able to crash Eclipse by trying to do operations that
> require credentials, like info or checkout. It pops up a dialog before it
> dies saying "An internal error occurred"..."invalid thread access".

That sounds like a memory overwrite problem. One option would be to
build APR and Subversion with pool debugging enabled and run eclipse
under valgrind. With debug info enabled and perhaps with optimization
disabled.

I'm not familiar with Subclipse, there is a fair amount of code. A
quick grep shows

  public class JhlPromptUserPassword implements UserPasswordCallback {

in

  package org.tigris.subversion.svnclientadapter.javahl;

so that's the pre-1.9 org.apache API. The ExampleAuthnOld.java I added
uses the same API and the keyring appears to work with 1.8. My program
just does the minimum to connect and authenticate. One option would be
to extend that program and produce a testcase that reproduces the
problem. Perhaps it needs several connections? Or multiple
authentication objects? Or multiple threads? Or ...

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2014-11-19 14:59:52 CET

This is an archived mail posted to the Subversion Dev mailing list.