Re: svn commit: r1639507 - in /subversion/trunk/subversion/tests/cmdline: basic_tests.py davautocheck.sh svntest/main.py

Branko Čibej <brane_at_wandisco.com> writes:

> On 13.11.2014 21:24, brane_at_apache.org wrote:
>> Author: brane
>> Date: Thu Nov 13 20:24:35 2014
>> New Revision: 1639507
>>
>> URL: http://svn.apache.org/r1639507
>> Log:
>> Mark basic_tests.py 38 as XFAIL if running DAV tests with a version of
>> HTTPd where mod_dav has an URL quoting bug.
>>
>> See: https://issues.apache.org/bugzilla/show_bug.cgi?id=56480
>
> Hey Ben,
>
> You fixed this issue in mod_dav. Could you take a minute to review this,
> please, especially the list of broken HTTPd versions? It appears that
> both OSX 10.8 and 10.10 ship a system HTTPd that has this bug, so I
> think it's useful to have this predicate in our test suite.

One problem is the inconsistent handling of the broken httpd versions.
Using 2.2.25, 2.4.5 and 2.4.6 leads to a build failure while running
configure. Using 2.2.26 and 2.4.9 allows the build but raises a runtime
XFAIL. I'm not sure how Subversion should handle a broken Apache; if
the user has an old Subversion installed, one that did not do the
detection, should we stop upgrades to a newer Subversion with security
fixes?

Putting the code in davautocheck.sh means that it triggers for

   make davautocheck

but not for

   make check BASE_URL=http://...

Perhaps we could move the code from davautocheck.sh to apache.m4. Have
apache.m4 set a make variable containing the version number and add a
make rule to export the value of the make variable in an environment
variable.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*