[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn-bench help output

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 6 Nov 2014 23:21:21 +0100

On Thu, Nov 06, 2014 at 09:52:45PM +0000, Andreas Stieger wrote:
> Hello,
>
> please review the attached patch for the svn-bench output. This file
> probably started life as a copy of it's svn equivalent.
>
>
> [[[
> Apply equivalent change to r1522518 to svn-bench help output
>
> * subversion/svn/help-cmd.c
> (svn_cl__help): No not show the version number in help output as
> --version is provided. Name it Subversion benchmarking tool.
>
> ]]]
>
> With kind regards,
> Andreas Stieger

+1, please commit.

Thanks!

> Index: subversion/svn-bench/help-cmd.c
> ===================================================================
> --- subversion/svn-bench/help-cmd.c (revision 1637176)
> +++ subversion/svn-bench/help-cmd.c (working copy)
> @@ -45,10 +45,9 @@ svn_cl__help(apr_getopt_t *os,
> {
> svn_cl__opt_state_t *opt_state;
>
> - /* xgettext: the %s is for SVN_VER_NUMBER. */
> - char help_header_template[] =
> + char help_header[] =
> N_("usage: svn-bench <subcommand> [options] [args]\n"
> - "Subversion command-line client, version %s.\n"
> + "Subversion benchmarking tool.\n"
> "Type 'svn-bench help <subcommand>' for help on a specific subcommand.\n"
> "Type 'svn-bench --version' to see the program version and RA modules\n"
> " or 'svn-bench --version --quiet' to see just the version number.\n"
> @@ -63,9 +62,6 @@ svn_cl__help(apr_getopt_t *os,
> N_("Subversion is a tool for version control.\n"
> "For additional information, see http://subversion.apache.org/\n");
>
> - char *help_header =
> - apr_psprintf(pool, _(help_header_template), SVN_VER_NUMBER);
> -
> const char *ra_desc_start
> = _("The following repository access (RA) modules are available:\n\n");
>
Received on 2014-11-06 23:22:12 CET

This is an archived mail posted to the Subversion Dev mailing list.