[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: pysvn does not build against 1.9-alpha2 because of incomplete type 'const svn_sort__item_t'

From: Ben Reser <ben_at_reser.org>
Date: Thu, 06 Nov 2014 11:55:53 -0800

On 11/6/14 5:10 AM, Nico Kadel-Garcia wrote:
> Out of curiosity, do the same issues occur with gcc on a modern box?
> Ther'e's a lot to like about MacPorts, but I don't think it's the
> primary build and testing platform for Subversion.

Yes gcc is going to have the same issues because the declarations he needs have
been removed from svn_sorts.h These declarations have been there since 1.0.
Prior to 1.0 they had names in the APR namespace, since it was expected this
functionality would be moved to APR. Before 1.0 we cleaned up that namespace
problem and marked them private (by documentation and by using __ in the
names). Of course since they were still in a public header they are
effectively public APIs. Bert noticed that there were a lot of these private
APIs added to the svn_sorts.h header since 1.8 on trunk and so he moved all of
them into a private header that isn't installed. This meant he moved the ones
that had been there since 1.0, thus breaking any 3rd party code that depended
on them.

Ideally we would have never exposed these. Ideally 3rd parties would have
observed the private markers and not used them.

I suggested that we resolve this by restoring the long standing private APIs
that had been exposed. While not adding any new APIs. If nobody objects to
that suggestion soon I'm going to just do it.
Received on 2014-11-06 20:56:58 CET

This is an archived mail posted to the Subversion Dev mailing list.