Re: svn commit: r1634906 - in /subversion/branches/svn-auth-x509/subversion: include/svn_x509.h libsvn_subr/x509.h libsvn_subr/x509info.c libsvn_subr/x509parse.c svn/auth-cmd.c tests/libsvn_subr/x509-test.c

On 30.10.2014 02:00, Ben Reser wrote:
> On 10/28/14 9:26 AM, Branko Čibej wrote:
>> Indentation is wrong.
> Whoops, somehow my code style setting got disabled when I wrote this and didn't
> notice it. Fixed in r1635359.
>
>> And I suggest using svn_iter_apr_array here.
>> ... and svn_iter_apr_hash here.
> Unless it's a big deal to you I'm not inclined to use those here. They feel
> very clunky for this use. For one thing I need to add another function for the
> callback that have only one line. For another I have to pass the pool into the
> callback baton since they both pass only a scratch pool.

I agree they're somewhat cluncky (but that's fixable). However, at least
svn_iter_apr_hash is faster (with a new-enough APR) than the most
obvious hash iteration loop.

C needs lambdas and closures ...

-- Brane
Received on 2014-10-30 04:25:11 CET