[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Search for libtoolize, not libtool

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 24 Sep 2014 13:00:43 +0100

Philip Martin wrote:
> James McCoy <jamessan_at_debian.org> writes:
>> -libtool=${LIBTOOL:-`./build/PrintPath glibtool libtool libtool15`}
>> +libtoolize=${LIBTOOLIZE:-`./build/PrintPath glibtoolize libtoolize libtoolize15`}
> APR has similar code in buildconf but it uses the order:
> libtoolize=`build/PrintPath glibtoolize1 glibtoolize libtoolize15 libtoolize14
> libtoolize`
> APR and Subversion both prioritize GNU libtool over plain libtool.  I'm
> not sure why APR prefers libtool 1 over libtool 2, perhaps uncertainty
> about how well 2 worked when it was released.  Subversion doesn't
> currently do that and I see no need for it to do so.
> I've committed a modification of the patch that also adds glibtoolize1
> and libtool14 in this order:
>   glibtoolize libtoolize glibtoolize1 libtoolize15 libtoolize14

Hi Philip. Sounds good, but it would be good to add your reasoning (above) into the log message and/or as comments in the code.

- Julian
Received on 2014-09-24 14:07:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.