[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Search for libtoolize, not libtool

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 24 Sep 2014 09:03:40 +0200

On Tue, Sep 23, 2014 at 10:45:19PM -0400, James McCoy wrote:
> Hi,
>
> build/buildcheck.sh performs a search for a variant of libtool in order
> to verify an acceptable version is available. However, the similar
> code in autogen.sh looks for and uses a variant of libtoolize.
>
> Since libtoolize is the tool actually performing useful work between the
> two, and buildcheck.sh fails the build if libtool isn't found, updating
> buildcheck.sh to look for libtoolize seems appropriate. This specific
> build failure does occur[0] when trying to cross-build subversion with
> Ubuntu's (and soon Debian's) Multi-Archified libtool packages[1].
>
> The attached patch, proposed by Helmut Grohne[2], makes said change to
> buildcheck.sh.
>
> [0]: https://people.debian.org/~doko/logs/20140912/failed-libtool/subversion_1.8.10-1_unstable_jdk-libtool.log
> [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682045
> [2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=761789#12
> --
> James
> GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <jamessan_at_debian.org>

There is at least one other libtool implementation that doesn't provide
the libtoolize program. The case I know of is the OpenBSD implementation
which is a compile time drop-in replacement that consumes builds prepared
with libtoolize. So I think we should at least keep trying libtool if
libtoolize can't be found.

We don't require tarball users to run autogen.sh so there is no dependency
on libtoolize in the tarball build. With the proposed change we're going to
require users to have GNU libtool installed to build Subversion from tarballs.

> Index: build/buildcheck.sh
> ===================================================================
> --- build/buildcheck.sh (revision 1627191)
> +++ build/buildcheck.sh (working copy)
> @@ -97,14 +97,14 @@
> esac
> fi
>
> -libtool=${LIBTOOL:-`./build/PrintPath glibtool libtool libtool15`}
> +libtoolize=${LIBTOOLIZE:-`./build/PrintPath glibtoolize libtoolize libtoolize15`}
> # Extract the libtool version number: everything from the first number in
> # the version text until a hyphen or space.
> -lt_pversion=`$libtool --version 2>/dev/null |
> +lt_pversion=`$libtoolize --version 2>/dev/null |
> sed -e 's/^[^0-9]*//' -e 's/[- ].*//' -e '/^$/d' |
> sed -e 1q`
> if test -z "$lt_pversion"; then
> - echo "buildcheck: libtool not found."
> + echo "buildcheck: libtoolize not found."
> echo " You need libtool version $LIBTOOL_WANTED_VERSION or newer installed"
> exit 1
> fi
Received on 2014-09-24 09:04:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.