Re: [VOTE] merge the log-message-templates branch to trunk
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 15 Sep 2014 08:58:37 +0100
Justin Erenkrantz wrote:
I just took a look at the FreeBSD patch  that Stefan mentioned. It actually inserts text both before and after the 'ignore' line, like this:
[... the automatic listing of changes goes here ...]
A log message template with a 'will be ignored' line in it would produce almost exactly this result with Stefan's current scheme. That would work for a single template. Multiple before-and-after templates concatenated wouldn't retain the overall before-and-after effect, unless the concatenation code were to split each template at the 'ignore' line found in it, and concatenate the top parts and the bottom parts separately.
Also I wonder, if this feature adds the template text before the 'ignore line', if we should give the user a configuration option to turn it off. I'm thinking of the scenario where a user on such a project is currently using their own work-around, so that introducing this feature could annoy them if there is no way to turn it off because their own work-around needs to remain in place for a while. But maybe that's over-cautious. Anyway, I am happy for this feature to be enabled by default, because obviously it doesn't do anything unless the log message template property is present.
This is an archived mail posted to the Subversion Dev mailing list.