[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Change prevprops in pre-commit

From: Kim Gräsman <kim.grasman_at_gmail.com>
Date: Mon, 8 Sep 2014 15:42:11 +0200

On Mon, Sep 8, 2014 at 3:26 PM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
>
> I think we should provide command line support for setting txnprops.
> The code is simple enough, the iterface is a bit harder. There was was
> some debate on IRC as to whether it should be
>
> svnlook propset -t txn
>
> or
>
> svnadmin settxnprop -t txn
>
> For svnlook it means adding a write subcommand to a program that at
> present is read-only. If we add "-r REV" support to be consistent with
> other subcommands then we would then need further options to run/bypass
> hooks. This would then overlap with the existing "svnadmin setrevprop".
>
> For svnadmin it means that a pre-commit needs to use different programs
> for reading and writing txnprops rather than just using svnlook, and the
> name new name "settxnprop" is a different pattern from the existing
> "propget" name.
>
> We will probably need some way to delete txnprops as well. There is
> currently a new-in-1.9 "svnadmin delrevprop" to delete revision
> properties, so either "svnlook propdel" or "svnadmin deltxnprop".
> Or perhaps the new subcommand to set txnprops should allow a way to
> delete as well?

This would be much appreciated, we talked about this this morning in
the wake of our Python hack modifying transaction files directly.

I don't know what the tools look like on the inside, but to me it
would be nice if the interface treated -r and -t as interchangeable,
so it was just a matter of choosing whether you wanted to poke at a
transaction-in-flight or an existing revision.

- Kim
Received on 2014-09-08 16:05:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.