[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1622937 -/subversion/trunk/subversion/libsvn_fs_fs/low_level.c

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Sun, 7 Sep 2014 14:32:20 +0200

On Sun, Sep 7, 2014 at 10:44 AM, Branko Čibej <brane_at_wandisco.com> wrote:

> On 06.09.2014 23:54, Bert Huijben wrote:
>
> The dirent is canonical test is not the right test for fspaths. Dirents
> are platform specific, while fspaths aren't. E.g. this breaks fspaths
> containing ':' on Windows.
>
> I think there should be a valid fspath API for this use case, and if not
> we should add it.
>
>
> It's called svn_fspath__is_canonical, and it already checks for the
> leading slash.
>

Thank you for fixing this!
(I've been about to commit the same change.)

-- Stefan^2.
Received on 2014-09-07 14:32:49 CEST

This is an archived mail posted to the Subversion Dev mailing list.