[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1622946 - /subversion/trunk/subversion/libsvn_fs_fs/rev_file.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Sun, 07 Sep 2014 10:30:32 +0200

On 07.09.2014 00:01, stefan2_at_apache.org wrote:
> --- subversion/trunk/subversion/libsvn_fs_fs/rev_file.c (original)
> +++ subversion/trunk/subversion/libsvn_fs_fs/rev_file.c Sat Sep 6 22:01:09 2014
> @@ -176,6 +176,9 @@ open_pack_or_rev_file(svn_fs_fs__revisio
>
> /* We failed for the first time. Refresh cache & retry. */
> SVN_ERR(svn_fs_fs__update_min_unpacked_rev(fs, scratch_pool));
> + file->start_revision = rev < ffd->min_unpacked_rev
> + ? rev - (rev % ffd->max_files_per_dir)
> + : rev;

Even though the precedence rules make this assignment behave as
intended, I would really, really prefer to have parentheses around the
ternary expression.

-- Brane
Received on 2014-09-07 10:31:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.