Re: Segmentation fault during diff generation

Bert Huijben wrote:
>> So here, attached, is an implementation of the post-filtering approach.
>> This is implemented using a common filter for repos-WC and WC-WC diffs.
>> [...]
>
> I really like this approach.
>
> I think we should commit it and improve from there. (I can't see why it
> would be worse than the current/old code)

Thanks. r1621978. (That's almost exactly the patch I posted here, but after I cleaned up some unused variables and obsolete comments.)

- Julian

> Good catch on missing a few skip implementations. The unified diff output
> handler currently never sets these flags, while the merge handlers do. (But
> we don't support driving the merge from these diff drivers yet)
>
> Your filter could be a start of using those skip flags though...
Received on 2014-09-02 15:23:20 CEST