Re: Segmentation fault during diff generation
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 2 Sep 2014 12:45:28 +0100
I (Julian Foad) wrote:
> The attached brute-force patch seems to fix many of the cases where changelist
> filtering was missing or wrong, but I don't much like it and haven't
> properly tested it.
So here, attached, is an implementation of the post-filtering approach. This is implemented using a common filter for repos-WC and WC-WC diffs.
>> Personally I would wish we could just do the changelist filtering in the
>> output layer, instead of in all the diff drivers separately... But the
>> current code doesn't properly guarantee access to the local working copy
>> paths to do that kind of processing there.
>> In many cases it prefers to just pass something url like. (Not necessary the
>> proper url)
> If filtering at the output layer is easier that's totally fine with me,
> anything as long as it's simple and consistent.
What do you think of the attached implementation?
I gave it a try by hand. I can't claim to have tested it thoroughly.
This is an archived mail posted to the Subversion Dev mailing list.