Re: svn commit: r1621387 - in /subversion/branches/authzperf/subversion/libsvn_repos: authz.c authz.h authz_parse.c

On 30.08.2014 22:42, Branko Čibej wrote:
> On 30.08.2014 21:37, Stefan Fuhrmann wrote:
>> I updated the wiki page now to make it match the code again, updated
>> terminology to make it match your API and (hopefully) addressed the
>> comments to had on the page. I left the comments in for you to review.
> OK, thanks! I'll try to get through the docs on Monday, then I'll have
> to fix the wildcard normalization logic in the parser to match the
> updated docs.

Stefan, I went through the docs (and commits); there are a couple new
comments in the doc, one is a minor nit, the other affects the rights
lookup workflow. IIUC, you already removed the foo/** to foo/*
normalization from the code?

I propose to remove the svn_authz_t::groups hash now, as I believe it is
not used anywhere any more. This will slightly reduce the memory
footprint of the parsed authz representation.

-- Brane
Received on 2014-09-01 10:19:34 CEST