[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1618869 - in /subversion/branches/authzperf/subversion: include/svn_string.h libsvn_subr/string.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Tue, 26 Aug 2014 19:15:15 +0200

On 26.08.2014 18:41, Ivan Zhakov wrote:
> On 19 August 2014 18:14, <brane_at_apache.org> wrote:
>> Author: brane
>> Date: Tue Aug 19 14:14:18 2014
>> New Revision: 1618869
>>
>> URL: http://svn.apache.org/r1618869
>> Log:
>> On the authzperf branch: Add a stringbuf helper function.
>>
> [..]
>
>> --- subversion/branches/authzperf/subversion/libsvn_subr/string.c (original)
>> +++ subversion/branches/authzperf/subversion/libsvn_subr/string.c Tue Aug 19 14:14:18 2014
>> @@ -496,6 +496,21 @@ svn_stringbuf_chop(svn_stringbuf_t *str,
>> str->data[str->len] = '\0';
>> }
>>
>> +void
>> +svn_stringbuf_leftchop(svn_stringbuf_t *str, apr_size_t nbytes)
>> +{
>> + if (nbytes > str->len)
>> + str->len = 0;
> As far I remember we have a API promise that svn_stringbuf_t->data is
> always valid nul-terminated string.

You are correct, this is an omission; thanks for pointing it out. Will fix.

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco | Realising the impossibilities of Big Data
e. brane_at_wandisco.com
Received on 2014-08-26 19:15:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.