[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] Revision property caching

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Wed, 20 Aug 2014 18:04:21 +0400

> [...]
> I haven't looked at the implementation, but if your description is correct,
> then we're definitely in trouble.
> I would have expected that the unversioned-metadata (i.e., currently only
> revprop) generation would always be updated regardless of cache settings,
> and never be cached. I presume changing the implementation to behave this
> way would fix the problem?

If you mean that we could entirely stop sharing the revprop generation across
multiple processes, it would probably work.

However, I am not entirely sure what was the reasoning behind that kind of
sharing. If this shared memory thing was an attempt to get rid of the file
parsing overhead, then I would say it is a good idea to choose correctness
in favor of an optimization that breaks things in half of the cases. But
there might be more to it.

> And by all means, do commit your failing test case.

Done in r1619105.

Evgeny Kotkov
Received on 2014-08-20 16:05:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.