[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Python bindings: core.Stream missing close method?

From: Alexey Neyman <stilor_at_att.net>
Date: Tue, 19 Aug 2014 15:08:13 -0700


It looks like the core.Stream class does not close the underlying streams. It
does save reference to a svn_stream_t wrapper in self._stream, but does not
call svn_stream_close() on its own deletion, nor does the auto-generated
svn_stream_t class do so.

Obviously, it can be closed by calling core.svn_stream_close(s._stream) - but
this accesses private fields not intended to be used as external interfaces.

Am I right that it leaks open streams? If I am - perhaps, fix as attached - to
implement the file-object-like behavior for core.Stream?


Received on 2014-08-20 00:08:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.