On Tue, Aug 12, 2014 at 11:47 PM, Stefan Fuhrmann <
stefan.fuhrmann_at_wandisco.com> wrote:
> Arrgs!! Random key combo made me sent the mail before completing it ...
>
>
> On Tue, Aug 12, 2014 at 11:29 PM, Stefan Fuhrmann <
> stefan.fuhrmann_at_wandisco.com> wrote:
>
>>
>> On Sun, Aug 10, 2014 at 3:56 PM, Evgeny Kotkov <
>> evgeny.kotkov_at_visualsvn.com> wrote:
>>
>
[...]
> I have found myself in the same situation as you before.
> A seemingly simple change causing lots of discussion.
> It's surprising and somewhat disheartening, but in the
> end the code has been better than it would have been
> without the discussions. The key is that everyone needs
> to stay constructive in their criticisms.
>
To be constructive, I implemented the feature in the db/uuid
instead of db/format - taking your code and commentary
where possible. That automatically covered the dump / load
issue and shortened the patch quite a bit. Cache keying
and structure description update are also addressed.
I did not implement an extension to 'svnadmin setuuid' to only
update the instance ID because I'm not sure I really want it.
A minor thing I did is to call the new feature 'instance ID'
instead of 'instance UUID' because there is no need to guarantee
global uniqueness. Our current implementation just happens
to generate UUIDs. Future code might use something else.
But that is a only a minor point.
-- Stefan^2.
Received on 2014-08-13 03:35:08 CEST