RE: [VOTE] Merge svn-auth-x509 branch to trunk?
From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 13 Aug 2014 00:55:37 +0200
Since WC-NG we tried not to introduce new functions with flag arguments as in general functions like that are hard to maintain, while it is easy to rev functions to add another separate argument. (Another less preferred option is using a struct with separate args)
I remember arguments from gstein but I have a hard time finding a mail reference.
I think this would be the first new flag style argument in a public function since 1.2 or so.... If possible I would try using a different pattern here.
I like the intermediate option of getting at least the feature merged to trunk without this function. I don't see any arguments against that.
On 12.08.2014 21:56, Ivan Zhakov wrote:
On 11 August 2014 20:51, Ben Reser <ben_at_reser.org> wrote:
I found macro as unnecessary hack in this case, while I like
Exactly. I want to leave svn_checksum_to_cstring_display() and do not
2. We currently use svn_checksum_to_cstring_display() as canonical
Brane asked me to reverted my branch changes for some reason, while I
I've reverted my branch changes in r1617225. So I'm leaving solution
My concerns are the following:
Btw it would be nice to have tests for
At this point, just reverting the change that introduced svn_checksum_to_cstring_display2 from the x509 branch would resolve your objections, right, Ivan? We can live with not having a canonical checksum representation for display purposes that's different from the one in our wire protocol, and we can certainly address this mess separately from the x509 parser — which is, after all, the main purpose of the branch.
To clarify, I would be against releasing the authn code as it is, with the extra info stored in the authn cache just because we don't have a cert parser on trunk; and I think the branch, even without the display changes, solves that problem just fine.
-- Branko Čibej | Director of Subversion WANdisco | Realising the impossibilities of Big Data e. brane_at_wandisco.comReceived on 2014-08-13 00:56:53 CEST
This is an archived mail posted to the Subversion Dev mailing list.