[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

From: Ben Reser <ben_at_reser.org>
Date: Tue, 12 Aug 2014 14:47:03 -0700

On 8/12/14 12:56 PM, Ivan Zhakov wrote:
> My concerns are the following:
> 1. Avoid unrelated branch changes
> 2. Have some function for converting checksum to canonical form:
> a) one option is just leave svn_checksum_to_cstring_display() and
> add svn_checksum_to_cstring_display_ex()
> b) another option is deprecate svn_checksum_to_cstring_display(),
> replacing existing callers with
> new svn_checksum_to_cstring_canonical(), but I think it's
> better do this on trunk to make review easier.

Per our discussion I'll just remove the svn_checksum_* changes on the branch.
After we get the X.509 stuff merged to trunk I'll commit something that changes
the checksum output formatting and that accommodates most of your comments. I
am still inclined to use flags so that the function can be used in multiple
differing cases.
Received on 2014-08-12 23:47:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.