[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1617507 - /subversion/trunk/subversion/libsvn_subr/debug.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Tue, 12 Aug 2014 17:42:09 +0200

On 12.08.2014 17:28, stsp_at_apache.org wrote:
> Author: stsp
> Date: Tue Aug 12 15:28:49 2014
> New Revision: 1617507
> URL: http://svn.apache.org/r1617507
> Log:
> * subversion/libsvn_subr/debug.c
> (debug_vprintf): Increase local buffer size so clients built with
> SQLITE3_DEBUG don't assert in SVN_DBG() because SQL statements exceed
> the buffer size in length.

The deeper question is, why is there even a single assert in the
debug_vprintf function? The buffers cannot overrun; and the fact that a
debug message was truncated is not a valid reason for asserting.

Those asserts should go away, IMO.

-- Brane

Branko Čibej | Director of Subversion
WANdisco | Realising the impossibilities of Big Data
e. brane_at_wandisco.com
Received on 2014-08-12 17:42:41 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.