[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] remove svn__strtol() and svn__strtoul()

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 7 Aug 2014 14:35:54 +0200

On Thu, Aug 07, 2014 at 02:27:15PM +0200, Branko Čibej wrote:
> On 07.08.2014 08:52, Stefan Sperling wrote:
> > On Thu, Aug 07, 2014 at 01:34:40AM +0200, Branko Čibej wrote:
> >> On 06.08.2014 23:23, Stefan Sperling wrote:
> >>> How about I commit my patch, and then someone else (you? Bert?) tunes
> >>> the implementations of svn_cstring_atoi*, perhaps reusing code from
> >>> svn__strto* but keeping the API promises intact?
> >> You'd be silently changing the semantics of public APIs. These are not
> >> currently documented to be equivalent to strtol & co., but they're
> >> implemented in terms of apr_strtol & co., which are just replacements
> >> for those platforms that do not have the standard <string.h> header.
> > So?
> So we can't go silently changing the semantics of our public APIs.
> Unless you can convince someone (me?) that this is a topic for API errata.
> -- Brane

I'd argue that it's an implementation detail.

In fact, I wasn't aware of this when I wrote the code! So it's clearly
unintended. These functions are supposed to expect strings that contain
numbers, not whitespace.
Received on 2014-08-07 14:41:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.