[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1612405 - in /subversion/trunk/subversion: include/private/svn_io_private.h libsvn_subr/io.c libsvn_subr/named_atomic.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Wed, 06 Aug 2014 22:59:41 +0200

On 06.08.2014 22:47, Stefan Fuhrmann wrote:
> On Fri, Aug 1, 2014 at 7:37 PM, Ivan Zhakov <ivan_at_visualsvn.com
> <mailto:ivan_at_visualsvn.com>> wrote:
> Stefan,
> It seems you broke the code (again): SVN_MUTEX__WITH_LOCK() will
> release THREAD_MUTEX immediately after file lock will be obtained.
> That means that access to shared memory will not be synchronized on
> posix platforms (!). And this also could cause undefined behavior when
> unlock() function will try to unlock THREAD_MUTEX without actually
> owning it [1].
> Thank you for spotting this! It's one of those "too obvious to see"
> snafus.
> The lock() is obviously supposed to keep the locks ... Fixed in r1615354.

I suggest you add that to the backport proposal.

-- Brane

Branko Čibej | Director of Subversion
WANdisco | Realising the impossibilities of Big Data
e. brane_at_wandisco.com
Received on 2014-08-06 22:59:39 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.