Re: Issues with bindings tests

James McCoy wrote:

> On Wed, May 14, 2014 at 07:26:20AM -0400, James McCoy wrote:
>> On Wed, May 14, 2014 at 03:35:50AM +0000, Daniel Shahaf wrote:
>> > James McCoy wrote on Tue, May 13, 2014 at 22:00:55 -0400:
>> > > I had tried the below patch but ran into some other issues that I didn't
>> > > have the time/experience to properly diagnose.
>
> There was extra cruft in that patch from a previous discussion.  Only
> the Makefile.in bit is relevant.  Trimmed patch attached.

Talking of cruft... Do you know why that "if" condition exists at all? Why do we set the library path only if the library path variable is named DYLD_LIBRARY_PATH or LD_LIBRARY_PATH -- are there some names for which we should not do this?

>   case "@SVN_APR_SHLIB_PATH_VAR@" in
>     DYLD_LIBRARY_PATH|LD_LIBRARY_PATH)
>       # append the required library paths to the variable

(I tried to run "svn blame" to look for clues to what the original author meant, but the repository server is currently not responding.)

- Julian
Received on 2014-05-19 12:11:51 CEST