[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r1592723: Add 'svnadmin delrevprop'.

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 9 May 2014 23:50:46 +0000

Julian Foad wrote on Sat, May 10, 2014 at 00:24:34 +0100:
> Hi Daniel. It looks like your change created this warning:
> subversion/svnadmin/svnadmin.c: In function 'subcommand_delrevprop':
> subversion/svnadmin/svnadmin.c:2304:27: unused variable 'filename'

Thanks Julian. I missed it (and so did svn-warnings). Fixed in r1593652.

Separately, your two emails make me wonder if we should change the
commit messages' format to include the first line of the log message in
the subject line. The https://git-wip-us.apache.org/ repositories can
do this, and I've found that the first paragraph of the log message
usually serves well as a summary of the change for STATUS purposes.

In fact, making the log messages more prominent may encourage us to
write better summaries.

Received on 2014-05-12 09:38:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.