Re: Allocation of read buffers (was Re: svn commit: r1535686 - in /subversion/branches/log-addressing/subversion: include/svn_error_codes.h libsvn_fs_fs/transaction.c tests/libsvn_fs_fs/ tests/libsvn_fs_fs/fs-fs-pack-test.c)

On 23 April 2014 14:50, Bert Huijben <bert_at_qqmail.nl> wrote:
> On Windows the default stacksize is 1 MB, and as we are in many cases ‘just
> a library’ we should try to be a bit on the safe side, especially when we
> call into other code -or are likely to be called from other code- that might
> have their own buffers.
>
>
> Until recently these buffers weren’t that big… Now that they are on trunk we
> should probably move them to a short lived scratch pool… or reduce them back
> to their original size.
>
I've vetoed increasing read buffer size recently and going to revert
r1586922: make SVN__STREAM_CHUNK_SIZE 16k again and implement
optimization and FSFS layer.

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com