[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1535686 - in /subversion/branches/log-addressing/subversion: include/svn_error_codes.h libsvn_fs_fs/transaction.c tests/libsvn_fs_fs/ tests/libsvn_fs_fs/fs-fs-pack-test.c

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Mon, 21 Apr 2014 17:49:27 +0200

On Mon, Apr 21, 2014 at 9:37 AM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:

> On 20 April 2014 22:38, Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
> wrote:
> >
> > On Sat, Apr 19, 2014 at 10:32 PM, Ivan Zhakov <ivan_at_visualsvn.com>
> wrote:
> >>
> >> On 25 October 2013 15:12, <stefan2_at_apache.org> wrote:
> >> > Author: stefan2
> >> > Date: Fri Oct 25 11:12:27 2013
> >> > New Revision: 1535686
> >> >
> >> > URL: http://svn.apache.org/r1535686
> >> > Log:
> >> > On the log-addressing branch: Automatically upgrade transactions from
> >> > physical to logical addressing mode for recently upgraded
> repositories.
> >> > Provide a test-case.
> >> >
> >> Hi Stefan,
> >>
> >>
> >> [...]
> >>
> >> > +/* Determine the checksum for the SIZE bytes of data starting at
> START
> >> > + * in FILE and return the result in *FNV1_CHECKSUM.
> >> > + * Use POOL for tempoary allocations.
> >> > + */
> >> > +static svn_error_t *
> >> > +fnv1a_checksum_on_file_range(apr_uint32_t *fnv1_checksum,
> >> > + apr_file_t *file,
> >> > + apr_off_t start,
> >> > + apr_off_t size,
> >> > + apr_pool_t *pool)
> >> > +{
> >> > + char buffer[4096];
> >> > +
> >> Why you're using non-standard sized buffer for IO operations on stack?
> >> It should be apr_palloc(SVN__STREAM_CHUNK_SIZE). Is not it?
> >
> >
> > No need to use dynamically alloc the buffer
> > but not using SVN__STREAM_CHUNK_SIZE
> > as clearly an oversight.
> >
> Your reply doesn't have any arguments why no need to use buffer from
> pool like we do in all other places.
>

You now have the chance to make your statement
actually true. Please fix the following occurrences
and check their callers for proper pool usage:

trunk/subversion/libsvn_delta/text_delta.c:923
trunk/subversion/libsvn_subr/io.c:805

-- Stefan^2.
Received on 2014-04-21 17:49:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.