[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[Review request] RE: svn commit: r1588772 - in /subversion/trunk/subversion: mod_dav_svn/repos.c tests/cmdline/commit_tests.py

From: Bert Huijben <bert_at_qqmail.nl>
Date: Sun, 20 Apr 2014 17:32:35 +0200

> -----Original Message-----
> From: rhuijben_at_apache.org [mailto:rhuijben_at_apache.org]
> Sent: zondag 20 april 2014 16:47
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1588772 - in /subversion/trunk/subversion:
> mod_dav_svn/repos.c tests/cmdline/commit_tests.py
> Author: rhuijben
> Date: Sun Apr 20 14:46:42 2014
> New Revision: 1588772
> URL: http://svn.apache.org/r1588772
> Log:
> Implement an initial fix for issue #4480. As noted in the code this patch
> might make this code report out of date in a few cases where we should
> allow
> a commit, but this is much safer than not reporting out of date where we
> should.
> As far as I can tell this check matches how we do things in the repos/fs
> commit api, so I hope somebody with more knowledge of these apis can
> confirm that this is the right fix to close issue #4480.

        Hi all,

This issue has been bothering me for weeks, because I couldn't think of a proper way to fix this.

I think this patch (improved by r1588778) resolves the issue, but I would welcome reviews.

If possible I would like to see this issue fixed in the next 1.8 and 1.7 releases as this issue allows breaking merge tracking by overwriting node properties without a proper out of date check.

Received on 2014-04-20 17:33:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.